Allow for geographies to exist between meta and seed geographies#217
Allow for geographies to exist between meta and seed geographies#217JoeJimFlood wants to merge 25 commits into
Conversation
|
Hi @JoeJimFlood this is great, I can take a closer look but a couple of things off the top of my head:
If you can tackle the first one before I can get to this PR, it would definitely expedite things! |
|
@nick-fournier Thanks for reviewing it! I actually had already agreed to write a unit test, though figuring out exactly how has been a challenge. Right now I'm leaning towards running the CALM example with and without a geography in between the District and PUMA levels and checking that the outputs are the same. |
|
@JoeJimFlood I fixed the surface issue of failed linting, that was easy, but I started running into some other issues with test failures. I think they have to do with linux/windows nuances. Which maybe that is what you might be running into? Will report back soon. |
Co-authored-by: Copilot <copilot@github.com>
Allow intermediate geographies
|
These look to just be linting errors, |
Allow intermediate geographies
As it currently stands, there is an implicit assumption in the code that the seed geography will be one level below the meta geography in the hierarchy. The CDOT implementation needs a geography in between the two. This pull request allows for any number of geographies in between the meta and seed geographies.